-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DensifyGeodesic
trait
#1208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor nits, but overall it looks good. Thank you!
@michaelkirk thanks for your review! I have added proposed changes |
I think you'll need to run cargo fmt, otherwise LGTM I'll leave it open for a couple days before merging in case anyone else wants to weigh in. |
I've just realised that there is already the following method: Do we still need this another implementation? |
Darn it. I'm sorry for not realizing this earlier. This seems related to #1181 |
Assuming #1216 gets merged, I've got a different approach that should supersede this, generically implementing Densify for all line measures (Haversine, Geodesic, Euclidean, etc.) You can see a WIP here: https://github.com/georust/geo/compare/mkirk/unify-densify?expand=1 |
CHANGES.md
if knowledge of this change could be valuable to users.This PR adds
DensifyGeodesic
trait that follows logic similar toDensifyHaversine
. However, the trait is only implemented forT = f64
as underlying Geodesic traits are implemented only for this type.